Fix up matching regex #1

JohnGarbutt · 2016-07-06T17:18:53Z

No description provided.

markuszoeller · 2016-07-06T18:02:26Z

api-ref-burndown.py

 for fname in sorted(glob.glob("%s/*.py" % TOP)):
    with open(fname) as f:
        fdata = {'filename': os.path.basename(fname)}
        content = f.readlines()
        done = True
        for key in PHASES:
-            if ".. %s\n" % key in content:
+            if "# %s\n" % key in content:
                fdata[key] = "TODO"
                done = False
                counts[key].append(fname)


You will also need to change the "index.html": http://paste.openstack.org/show/526602/

Line 77 should probably be: m = re.match('-# needs:(.*)', line)

The api-ref source need .. for comments, we need #.

markuszoeller · 2016-07-06T18:41:35Z

Maybe there is a bug in seans code when it writes the "data.csv" file for the burndown chart on the top of file "index.html". I needed to add manually the line
date,needs:fix_opt_description,needs:check_deprecation_status,needs:check_opt_group_and_type,needs:fix_opt_description_indentation,needs:fix_opt_registration_consistency
at the very top of "data.csv", otherwise the "d3.js" cannot display the time series data in "data.csv".

markuszoeller · 2016-07-07T11:51:41Z

My full patch: http://paste.openstack.org/show/526868/

Fix up matching regex

cea8bf9

markuszoeller reviewed Jul 6, 2016
View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix up matching regex #1

Fix up matching regex #1

JohnGarbutt commented Jul 6, 2016

markuszoeller Jul 6, 2016

markuszoeller Jul 6, 2016 •

edited

markuszoeller commented Jul 6, 2016 •

edited

markuszoeller commented Jul 7, 2016

Fix up matching regex #1

Are you sure you want to change the base?

Fix up matching regex #1

Conversation

JohnGarbutt commented Jul 6, 2016

markuszoeller Jul 6, 2016

Choose a reason for hiding this comment

markuszoeller Jul 6, 2016 • edited

Choose a reason for hiding this comment

markuszoeller commented Jul 6, 2016 • edited

markuszoeller commented Jul 7, 2016

markuszoeller Jul 6, 2016 •

edited

markuszoeller commented Jul 6, 2016 •

edited